search

FactoryBoy / factory_boy

A test fixtures replacement for Python
https://factoryboy.readthedocs.io/
MIT License
3.48k stars 392 forks source link

Elasticsearch DSL factory? #656

Open barseghyanartur opened 4 years ago

barseghyanartur commented 4 years ago

The problem

It would be nice to have an Elasticsearch DSL factory included. At the moment I use my own custom (factory_boy based) one which I have to copy among different projects.

Proposed solution

Please, tell me if you're interested in a PR.

rbarrois commented 4 years ago

I like the idea ! However, I'm wondering whether it should live inside the factory_boy codebase, or as a separate package - kinda like factory_boy-peewee or factoryboy-gaendb.

If we go the "outside project" route, it could absolutely live within the FactoryBoy organization, though ;)

jeffwidman commented 4 years ago

Great idea. I prefer it as a separate package under the FactoryBoy organization, that just feels cleanest to me, while still being easily discoverable since in this org (and should be linked to from the main FactoryBoy docs)

barseghyanartur commented 4 years ago

I'll come up with a package then and let you know. Thanks!