Obviously the two inlines in parser should be fixed to use one of the function definitions, but what do I do with the multiple definitions? frontend-utils depends on parser now, but quite minimally, and I don't want to just reach in and use ensure-ends-with-newline. Really, what is that function doing in parser at all? It belongs in some generic string-utils namespace, not in parser.
So, if nobody objects, I'm just going to move that function into drake.utils, and have both namespaces use it from there.
dirtyvagabond
commented
10 years ago
I noticed that the same function is defined in drake.parser and drake.clj-frontend-utils; furthermore, its definition is inlined twice in drake.parser.
Obviously the two inlines in
parsershould be fixed to use one of the function definitions, but what do I do with the multiple definitions? frontend-utils depends on parser now, but quite minimally, and I don't want to just reach in and useensure-ends-with-newline. Really, what is that function doing inparserat all? It belongs in some generic string-utils namespace, not in parser.So, if nobody objects, I'm just going to move that function into drake.utils, and have both namespaces use it from there.