search

Factual / drake

Data workflow tool, like a "Make for data"
Other
1.48k stars 110 forks source link

Timestamp should be checked when specify target by tags #137

Closed calfzhou closed 10 years ago

calfzhou commented 10 years ago

(with Drake v0.1.6)

For example there is a simple Drake workflow:

b <- a
    cat $INPUT > $OUTPUT
    echo done >> $OUTPUT

%t, c <- b
    cat $INPUT > $OUTPUT
    echo done again >> $OUTPUT

And I have already have the latest files a, b and c.

Now if I run drake with target c, it will check c's timestamp and will actually do nothing:

$ drake --preview c
Nothing to do.

But if I run drake with target %t, it will NOT check timestamp but force re-run matched steps:

$ drake --preview %t
The following steps will be run, in order:
  1: %t, c <- b [via tag]

I suggest that when specifying target by tags, timestamp should also be checked to avoid useless run.

amalloy commented 10 years ago

Duplicate of #73?

calfzhou commented 10 years ago

Thanks! I didn't find this existing issue. I'll close my issue.

Hope that #73 could be fixed ASAP.