Let user be less dependent on his FS layout

Factual / drake

Data workflow tool, like a "Make for data"

Other

1.48k stars 110 forks source link

Let user be less dependent on his FS layout #222

Open seregasheypak opened 8 years ago

seregasheypak commented 8 years ago

https://github.com/Factual/drake/issues/221

chen-factual commented 8 years ago

@dirtyvagabond do you know why this was here? I'm looking in /usr/include/linux/limits.h and PATH_MAX is defined as 4096. I did some Googling and the only reasonable explanation I could turn up was Windows has a 260 char limit, in which case we should greatly increase this limit.

dirtyvagabond commented 8 years ago

@chen-factual @seregasheypak my best guess is what Chen says, we were worried about Windows (or some other OS that has a low number). i can imagine that if this breaks at runtime it could be confusing/irritating so it's nice to have the explicit safeguard.

would one of you be willing to make this config dynamic, based on some minimal logic that tries to confirm a friendly OS before providing the larger number? or some similar solution that doesn't blindly assume a larger max?

chen-factual commented 8 years ago

@seregasheypak since you've already got the PR, would you like to take this on? You can use something like Apache SystemUtils (stack overflow thread)