search

Factual / factual-clojure-driver

Officially supported Clojure driver for Factual's API.
Other
20 stars 6 forks source link

Does not work with Clojure 1.7.0 #13

Closed timothypratley closed 9 years ago

timothypratley commented 9 years ago

Works fine with 1.6.0, but put 1.7.0 in your project and:

IllegalStateException Attempting to call unbound fn: #'clj-http.client/update clojure.lang.Var$Unbound.throwArity (Var.java:43)

Suggest updating clj-http dependency?

mavericklou commented 9 years ago

http://dev.clojure.org/jira/browse/CLJ-1604 @timothypratley The AOT compile is removed on the latest develop branch, but not released in any version. Have you tried removing AOT compile? It works for me.

Our clj-http lib is introduced by oauth-clj library and it is a pretty out-of-date version. I need more time playing with latest clj-http lib to see if everything works for both our driver and oauth-clj.

timothypratley commented 9 years ago

Hi Maverick, Yup that makes sense - thanks! Yes I downloaded the main branch and installed it, and it works with 1.7

mavericklou commented 9 years ago

@timothypratley Still we will moving forward, upgrade dependencies, make it work with latest clojure and release it together with no-AOT-compiling.

timothypratley commented 9 years ago

Great :) Thank you.

mcramm commented 8 years ago

Looks like this issue is still in play, affecting 1.8. Any updates?

dirtyvagabond commented 8 years ago

hi @mcramm looks like nobody has had time to attend to this. you have any interest in making the upgrade?

mcramm commented 8 years ago

@dirtyvagabond Yup - I can bump the minor version in a PR. By "upgrade" did you want me to deploy to Clojars too?

dirtyvagabond commented 8 years ago

thanks @mcramm i accepted your merge and deployed 1.5.3 to Clojars. (Apologies, I didn't realize that was all that was blocking this, or I should I have done this a long time ago)

mcramm commented 8 years ago

@dirtyvagabond - no problem at all! Glad it got merged. Thanks! :smile: