Factual / geo

Clojure library for working with geohashes, polygons, and other world geometry
Eclipse Public License 1.0
301 stars 17 forks source link

Switch proj4j to locationtech release #44

Closed willcohen closed 5 years ago

willcohen commented 5 years ago

Locationtech's proj4j is now officially released as 0.2.0, so we can use that as the upstream projection dependency. In addition to its ongoing bugfixes, this also means that we can shed all of the extraneous scala and other dependencies that came with geotrellis's fork (this 0.2.0 release is based off of that fork). The downside is that this means that create-transform in the crs namespace now has a different group ID, which technically means that this would be a major version breaking change like 2.0.

willcohen commented 5 years ago

@worace Also worth thinking about if we want to implement removing the alias added in #42, if the breaking change to 3.0 is happening already.

worace commented 5 years ago

I'd be excited to have these all reconciled, so maybe it's worth it. It feels a little excessive since we just had a major version a couple months ago, but on the other hand versions don't really cost us anything and it's not like there will be a lot of upgrade pain for anyone. So probably should just go ahead and do it.

willcohen commented 5 years ago

Sounds good. #43 still needs more thought, but I just removed the #42 alias, so I think this one is ready to go.