search

Factual / geo

Clojure library for working with geohashes, polygons, and other world geometry
Eclipse Public License 1.0
302 stars 17 forks source link

Add testing for openj9, removing use of deprecated spatial4j functions #59

Closed willcohen closed 5 years ago

willcohen commented 5 years ago

Using OpenJ9 was causing the midje tests to fail occasionally and unpredictably. Switching away from the deprecated functions in JtsSpatialContext seems to correct this issue. This also means that jts-earth in geo.spatial is no longer necessary, since all functions can be called using only earth instead.

In addition to these changes, this PR adds OpenJ9 to the test matrix, using jabba to manage jdk versioning.

willcohen commented 5 years ago

Configuring travis to stop failing due to incorrect certificates was a little finicky. It seems like updating the distro to xenial, using an updated version of leiningen installed directly, and restarting various builds on the PR a few times has gotten everything to pass. It's possible that some kind of caching behind the scenes was complicating this -- hopefully it's all shaken out now.

worace commented 5 years ago

It seems like updating the distro to xenial, using an updated version of leiningen installed directly, and restarting various builds on the PR a few times has gotten everything to pass

Jeez, sounds complicated, but nice work tracking all that down.

This looks good; happy to get off of that deprecated jts method before v3.

willcohen commented 5 years ago

Sounds good -- just in case, if for some reason travis breaks again after the merge to master I'll prioritize fixing that in a separate PR to be merged before 3.0.