search

Factual / open-dockerfiles

Factual's open source dockerfiles
MIT License
27 stars 26 forks source link

Fix add-users script #2

Open ndigati opened 8 years ago

ndigati commented 8 years ago

Fixes the issue where sometimes the add-users script would not work because it would error out and exit before chown or chmod all the files it was supposed to.

One case I found for this is when a users home directory had no files the xargs command would fail.

Changes that happened:

  1. Clean up the Dockerfile a little bit, and update README
  2. Fix find and xargs commands in add-users script
    • add -r to xargs to not process empty arguments passed to it (when no files in users home directory)
    • add -mindepth option to find to only look at files/folders in the users home directory
    • fix typo in Directory permissions variable
  3. Added changes discussed in comments in 969e2f5bba2379a39fe901591d0e9b11f4272dc7
  4. Added log files for services in supervisor
diogopms commented 7 years ago

Hey @ndigati, can we merge this PR? Thanks for doing this docker image 👍

This is the perfect use case for my ip camera using a s3 bucket 🙏