search

FacultyCreative / ngActiveResource

Connects business objects and REST web services for Angular.js
255 stars 34 forks source link

Port removed #21

Closed brayniverse closed 10 years ago

brayniverse commented 10 years ago

How come you're removing : from the url here? It only seems to remove my port number. 

url = url.replace(/\:\w+/, '');

I didn't want to make a pull request because I don't know why it's there in the first place.

brettshollenberger commented 10 years ago

That's a good question. I thought I had tested for the port, but I will look at this in a moment :)

facultymatt commented 10 years ago

It's worth noting older versions of angular had issues where the port (because it also started with :) was stripped from the url. The way to get around it is outlined here: http://stackoverflow.com/a/19800965/1738217

This is fixed in new angular but look like we have a similar regEx in ngActiveResource that causes trouble.

On Wed, Feb 19, 2014 at 3:56 PM, Brett Cassette notifications@github.comwrote:

That's a good question. I thought I had tested for the port, but I will look at this in a moment :)

Reply to this email directly or view it on GitHubhttps://github.com/FacultyCreative/ngActiveResource/issues/21#issuecomment-35547406 .

Matt MillerCreative Developerm 609.335.4417 twt @mattmillerart http://twitter.com/#!/mattmillerart

faculty twt @facultycreative http://twitter.com/#!/facultycreative w www.facultycreative.com

2424 E. York Street Suite 233 Philadelphia Pa. 19125