search

FacultyCreative / ngActiveResource

Connects business objects and REST web services for Angular.js
255 stars 34 forks source link

Fix #21 #30

Closed brayniverse closed 10 years ago

brayniverse commented 10 years ago

This hotfix worked for me, however I can't speak for the majority.

brettshollenberger commented 10 years ago

@brayniverse - Currently the test suite is failing with this change. Can you write failing test for this, and make these others pass?

brayniverse commented 10 years ago

Hey @brettshollenberger, I did a bit more digging around to see if I was just covering up a bug elsewhere and found you were using this regular expression \:[a-zA-Z_]+ elsewhere and thought it was a better idea to modify this PR to be more consistent with the rest of the module. What do you think?

brettshollenberger commented 10 years ago

@brayniverse I updated that regex and fixed on 0.7.4. Thanks for finding this!