search

FadedLocks702 / homework-landingpage02

0 stars 0 forks source link

Feedback on assignment 2 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #2 Project: Styling with CSS

Description

A hot, new NY Tech Startup, Relaxr, has approached you to help them develop a new landing page for their company. They've handed you the design file for the site, along with the copy and assets. You need to take these files and turn it into a landing page.

Student: Christian Contaoi

Project URL: https://github.com/FadedLocks702/homework-landingpage02
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a reset.css or normalize.css file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Use at least two flex containers, each with at least two flex items x
Style your text with the Google Fonts provided by your style guide n/a
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 9/12
barryross commented 7 years ago

Hey Christian,

Nice work on this assignment! I can see how much you are putting into this through your commit history!

Overall, you are doing some really great things! Great work linking the background image, and playing around with different CSS properties (buttons, for example).
Looks like you may have had some trouble with the reset.css/normalize.css requirement, and I was also looking to see 2 flex containers (see above requirement). I have posted the sample solution which you may find helpful to review: https://github.com/ga-students/FEWD_SM-31/tree/master/Unit_3/sample_solutions/assignment_2_sample_solution

Please see inline comments for additional info, and let me know if you have any specific questions!

Thank you, and keep up the fantastic work!