search

Faeranne / github-todo

Github webhook to create issues for TODO items in commits.
3 stars 2 forks source link

fix #16 - return instead of commitDone #20

Closed groovecoder closed 10 years ago

groovecoder commented 10 years ago

Hmm ... really wish we had a test around parseCommits so I could test this more easily. (I tried enabling issues on my own repo and adding my own heroku app as a web-hook, but it crashed?)

But, this is what I propose for #16 ... if it works.

Faeranne commented 10 years ago

I should probably add instructions for publishing to heroku for testing. Right now, you need to add an oauth token to the OAUTH_TOKEN env on heroku.

Faeranne commented 10 years ago

The error is caused by a missing parentisis from an earlier commit. Merge in the latest master and resubmit.

Faeranne commented 10 years ago

So parseCommit should only call cb one time. The suggested PR is causing it to be called on every listed file. This is causing duplications, should multiple commits be submitted. I do like the idea if we could filter out duplications.

Faeranne commented 10 years ago

Going to try an async lib instead.