search

FahimF / FloatLabelFields

Text entry controls which contain a built-in title/label so that you don't have to add a separate title for each field.
MIT License
1.19k stars 107 forks source link

Draw borders and fixed issue with font #5

Closed jfoc2009 closed 8 years ago

jfoc2009 commented 9 years ago

To changes: No user can set in IB if border lines will be used for each edge (Left, Right, Bottom, Up). And TextField loses his font configuration being set to title font when hideTitle is called. This issue is now fixed

FahimF commented 8 years ago

Thank you for your pull request. My apologies for taking so long to get to these changes. I did not merge them in for the following reasons:

  1. I did not want the placeholder to have the same colour as the title - I wanted the placeholders to appear like they do for other Apple controls.
  2. I could not replicate the bug with the TextField fonts. Can you please elaborate if you still want me to integrate this change? If can replicate it, I will add a fix. (I've modified the sample project to include a custom font for the floating title now so that this issue can be tested easily.)
  3. I need to consider the border lines setting and see if this is needed since IB already has the border style setting. If I think this would be useful, will add that to the next release of the code.