search

FailcoderAddons / supervillain-ui

Custom World of Warcraft User Interface
32 stars 23 forks source link

Unable to Remove Bars From Paging #149

Open baoist opened 7 years ago

baoist commented 7 years ago

Paging between bars (by default Shift+[Mouse Scroll Wheel]) appears to have broke in a recent release. Previously you could remove which bars were paged through via the "Game Menu->Interface->ActionBars" panel, but appears this option is now ignored. Ideally if you checked all "Remove Bar n Action Page", you would scroll/page between bars 1 and 2. As of now it scrolls through every bar.

Through manual testing, I believe it happened in https://github.com/FailcoderAddons/supervillain-ui/commit/b0161872e5b0a2294c7d04f1965423904f883685. Rolling back to https://github.com/FailcoderAddons/supervillain-ui/commit/02c8f2dec51fc95df2145d69e81d8b6c8a7647fc works as a temporary solution.

finalsliver commented 7 years ago

@joeymagz out of my depth on this one. can't see anything in your commit that should be doing this.

joeymagz commented 7 years ago

Do you have screenshots (or gifs) of what you're talking about by any chance? I can't reproduce this.

baoist commented 7 years ago

Yep, I can create them in a few hours and add them.

baoist commented 7 years ago

Paging on 02c8f2dec51fc95df2145d69e81d8b6c8a7647fc. Paging on master.

That being shown, I'm no longer confident it broke in b016187, I tried to use a zip from that before master and it appeared to work.

baoist commented 7 years ago

Was there any update on this; can I do any more to assist?

joeymagz commented 7 years ago

I can't find anything that would break paging with those commits.

baoist commented 7 years ago

@joeymagz Removing commit https://github.com/FailcoderAddons/supervillain-ui/commit/8262f6f84c6554ffde04a636eefe711630963d6b resolved this issue for me.