search

FailcoderAddons / supervillain-ui

Custom World of Warcraft User Interface
32 stars 23 forks source link

Please optimize unitframes a bit #188

Open Elowan opened 6 years ago

Elowan commented 6 years ago

hello, I just logged CPU times of my addons and I saw, that SVui unitframes are taking up the most CPU time, by far! (2nd was weakauras2, 3rd Skada and SVui Unitsframes was as much as both combined)

Turning off the raidframes and switching to "simple" player/target unitframes, instead of "super" did not change a thing.

Please try to optimize them - in the meantime I will use some replacement unitframes for raiding, because the CPU usage of SVui frames is way too high and cost a lot FPS (around 15)

Best Regards

finalsliver commented 6 years ago

Not noticing this on my end. so can't confirm.

@joeymagz can have a look when he has time.

Elowan commented 6 years ago

hi,

what addon did you use to measure? I was using: https://wow.curseforge.com/projects/addons-cpu-usage and tested during Antorus hc encounters (Coven and High Command)

Like I said, SVui unitframes was like 3.x seconds, WeakAuras2 and Skada around 1.5 seconds, each. (everything under 1 sec is kind of òk-ish") From other sources, the numbers for Skada and WA tends to be plausible.

Hmmm - maybe I got a bug here, with my frames? I was reading a lot of stuff, regarding CPU usage an (unit)frames - maybe there is some aura-/buffs-filter(s) on the frames, that draining so much CPU time.

finalsliver commented 6 years ago

"because the CPU usage of SVui frames is way too high and cost a lot FPS (around 15)" that makes it an easy reference.

I get no frame drops with raid frames active in solo content, lfr or heroic raiding. no symptom to need the profiling. considering I've been running around at 40 odd fps for the last year or so such drops would be very visible.

and as I said, unable to confirm. it will still be looked at eventually.

Elowan commented 6 years ago

uuuhhmmm, ok. I will eliminate the 2nd and 3rd highest CPU users and do a few more tests, to make sure, nothing else is wrong with my SVui install. Maybe I will deativate all other addons and see, if there is one addon, that is using some SVui lib or something like this. this could also lead to a high cpu usage of SVui frames, if another addon borrows stuff from it

Elowan commented 6 years ago

for now, I was only able to test a bit, by solo-raiding some old content (without full raidframes). I´ve made sure, that no buff-filters were active for the unit-frames. I also got rid of "target-target-frame" (disable) and now I got good results ! A LOT less CPU usage, than before. Maybe the fact, that I was filtering the unit´s buffs was too CPU intensive.

will check again by tomorrow evening, when in full raid and see, if CPU time for the unitframes still stay low ;)

Elowan commented 6 years ago

OK - so I did some more testing in a full raid last night. The SVui unitframes rate second, of what is most CPU hungry. I understand, that things like unitframes draw some "power" from the cpu, because they´re allways "on" and updating very frequently. I will test another unitframe-addon (Ouf with p3lim, what is known to draw little resources) and compare the results with SVui