No warning of changing raid instances when awarding loot

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create and start a raid for an instance.
2. Get saved to the instance.
3. Roll and award items to members of the raid.
4. Start and get saved to a new raid instance.
5. Roll and award items to members of the raid without changing the current
raid.

What is the expected output? What do you see instead?
There is no warning that you are about to award loot in one instance and
have not created a new raid according to the mod.  We should be able to
correlate a raid ID to our named IDs.  Either allow the addon to rename our
current raid or assign a raid ID to our named raid.

Original issue reported on code.google.com by govtgeek on 10 Mar 2008 at 5:34

[GoogleCodeExporter]

There's an event that is thrown when you are saved to an instance [I think the 
addon 
actually looks for this at the moment, although it doesn't do anything 
anymore].  
Having that event handler print "You have been saved to a new instance; do you 
wish 
to create a new raid?" would be a fairly straightforward solution to the 
"forgot to 
start a new raid" issue, although it wouldn't help when you're tracking two 
raids 
simultaneously across multiple nights.  That'll require a more fundemantal 
redesign 
of the entire raid ID system.

Original comment by dennis.z...@gmail.com on 10 Mar 2008 at 10:54

[GoogleCodeExporter]

If we are able to either save the raid ID under the given name, it should be 
just as
easy to search our list of raids and suggest the raid to use.  It could be as 
simple
as creating a new table that holds IDs and raid names.

I do know we have to be careful about having loot drop before a boss is 
dropped.  Are
you saved to an instance the moment a BOP epic drops?

Original comment by govtgeek on 10 Mar 2008 at 11:05

[GoogleCodeExporter]

I believe you are not saved under that circumstance, but I can't seem to verify 
it.

I am hesitant to tie instance IDs too closely with the addons raid IDs.  It 
seems to 
me that having two instances tied to one set of loot isn't so absurd as to 
warrent 
making it impossible, even if our current loot rules don't call for it.  The 
alternative is more reasonable, however: there's little to be gained from 
splitting 
a karazhan in half.

Keeping instance IDs and raid IDs independant have a couple fringe benefits on 
its 
own, however.  Most notably, it allows you to setup, and even assign loot, 
prior to 
actually zoning in.  

If currentRaid is removed from the saved variables, and an intelligent raid 
selection method is put implemented, the only time the addon could really get 
confused is if you go immediately from one raid to another without logging off 
in 
between; and in those situations, you should really be aware enough of what's 
going 
on to remember to switch raids.

It took me over two hours to write this, and I really didn't say much ><

Original comment by dennis.z...@gmail.com on 11 Mar 2008 at 7:48

[GoogleCodeExporter]

I understand the idea of wanting to allow the addon to handle spanning multiple
instances.  I hadn't thought of assigning loot beforehand, but that's an 
interesting
idea.

Maybe we can have a 'lastInstanceID' flag that we can use to notify the user 
when a
roll is attempted if the current raid ID is not the same as the last raid ID 
that
loot was rolled in?

Original comment by govtgeek on 11 Mar 2008 at 4:15

[GoogleCodeExporter]

Let me expand a bit on what was on my mind.

You log on, and your currentRaid is nil.  You do '/swloot startraid'  If you 
are in 
an instance with a saved ID, the addon finds a raid associated with that ID and 
resumes tracking it.  Otherwise, it resumes whatever your last raid was [this 
information is saved, for simplicity].  '/swloot startraid NewRaidName' 
bypasses 
this, and selects NewRaidName, creating it if neccessary.

You continue on killing things.  If at any point you get saved to an instance, 
currentRaid gets reset again if it has other instance IDs associated with it.  
If 
you want to add onto the previous raid, you simply do 'startraid'; if you want 
to 
start from scratch you do 'startraid Name'.  

You award a piece of loot.  The addon checks your current instance ID; if it is 
not 
associated with your current raid, it checks previous raids.  If one of them is 
associated with the instance ID, it either refuses to award the loot or 
switches you 
to that raid and awards it there.  If none of them are, it associates the 
instance 
ID with the current raid, and continues on as normal.

You finish that raid, and decide to move onto a different one.  While in the 
air, 
the advance party 9-mans the first boss and loots the one item you really 
wanted.  
You grudgingly award the loot to the proper person.  The addon notices that you 
are 
awarding loot to a raid but none of the associated instance IDs are applicable. 
 It 
spits out a warning, and doesn't award the loot.  A second attempt suppresses 
the 
warning, and the loot is distributed as expected.

That's pretty much every case I can come up with, except one or two that really 
just 
comes down to user error...attempting to award to a ZA raid while inside Kara 
will 
simply cause confusion no matter how you look at it.

Original comment by dennis.z...@gmail.com on 11 Mar 2008 at 5:09

[GoogleCodeExporter]

Okay, I had to re-read the last two responses from Dennis.  Let me put in cases 
and
you can tell me what happens. ;)

Case 1: I am not saved to Karazhan, but we have entered the instance.  BOP epic
drops.  Let's assume that you get saved at that point since we don't really 
know.  I
type /swloot startraid.

Case 2: I am late to a fresh Karazhan.  The group has downed Attumen and been 
saved
to the instance.  I type /swloot startraid lateisme.  I assign the loot.  I 
enter the
instance and instantly become saved.  We down Moroes and I do /swloot roll 
<item>.

Case 3: I log off after tracking ZA.  I run Karazhan the next day.  We have 
killed
Attumen and I type /swloot roll <item>.

Case 4: I am saved to Karazhan ID 2274260.  I run ZA and remember to switch it 
over.
 I come back to Karazhan to finish Prince.  I forget to type /swloot currentraid
2274260.  What happens when I type /swloot roll <item>?

Original comment by govtgeek on 11 Mar 2008 at 5:45

[GoogleCodeExporter]

Case 1: Your last raid is loaded, with a message making it clear which one is 
in 
use.  When you award the epic, you will get an error saying the addon believes 
you 
might have the wrong raid selected because your instance ID does not match one 
it 
has on file.  If you award it a second time, it assumes you know what you're 
doing 
and awards the loot as expected.

Case 2: You are told you aren't tracking a raid because when you got saved 
everything got cleared as a precautionary measure.  typing '/swloot startraid' 
will 
reload 'lateisme' and allow you to continue on as normal.

Case 3: You are again told you aren't tracking a raid, because your current 
raid 
isn't saved between sessions.  You create a raid however you like, and continue 
on 
as normal.  In this case, if you do '/swloot startraid' the ZA raid will be 
loaded 
and you end up back in Case 1.

Case 4: The addon spits out an error saying that raid '2274260' is associated 
with 
your current instance.  It then either switches to '2274260' and awards the 
loot as 
you'd expect, or waits for you to make the switch.  Either way, the ZA raid 
isn't 
touched so long as you are inside Karazhan.

Original comment by dennis.z...@gmail.com on 11 Mar 2008 at 9:15

[GoogleCodeExporter]

Original comment by dennis.z...@gmail.com on 15 Apr 2008 at 2:51

• Changed state: Fixed