codecov-commenter
commented
1 year ago Codecov Report
Merging #245 (9ed47ed) into main (07f4ef3) will increase coverage by
0.06%. The diff coverage is85.71%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 82.62% 82.68% +0.06%
==========================================
Files 69 69
Lines 6865 6896 +31
==========================================
+ Hits 5672 5702 +30
- Misses 1193 1194 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| pallets/roles/src/lib.rs | 77.77% <ø> (ø) |
|
| pallets/roles/src/tests.rs | 100.00% <ø> (ø) |
|
| runtime/src/lib.rs | 10.09% <ø> (ø) |
|
| pallets/roles/src/types.rs | 91.37% <66.66%> (-4.78%) |
:arrow_down: |
| pallets/asset_management/src/functions.rs | 88.36% <73.33%> (-1.09%) |
:arrow_down: |
| pallets/asset_management/src/lib.rs | 77.29% <100.00%> (+0.22%) |
:arrow_up: |
| pallets/asset_management/src/tests.rs | 99.65% <100.00%> (+0.01%) |
:arrow_up: |
| pallets/tenancy/src/lib.rs | 82.14% <100.00%> (+2.14%) |
:arrow_up: |
| pallets/tenancy/src/types.rs | 100.00% <100.00%> (+100.00%) |
:arrow_up: |
| pallets/nft/src/functions.rs | 68.26% <0.00%> (-0.97%) |
:arrow_down: |
| ... and 8 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The new
RequestedRolesstorage was not being updated, and as a result, new roles requests (seller, servicer) were not found. I also updated the Notary role creation to use this storage, as there is currently no referendum system similar to the one used for Representatives. One Question remains: with the use ofRequestedRolesstorage for Approval to facilitate the front-end design,NotaryApprovalList,SellerApprovalList, andServicerApprovalListstorages are no used anymore. This needs to be clarified...