Resume/Interrupt transports consistently

[rbx]

• Resume transports before state callbacks & handlers.
• Interrupt transports on new transitions.

Solves #428.

[rbx]

The failures happen because there is a race:

1. Device::ResetWrapper() is clearning the transports container.
2. Control::RunShutdownSequence() of a plugin is calling ChangeDeviceState(DeviceStateTransition::Auto);, which leads Device::InterruptTransports(); via SubscribeToNewTransition(. So, one is accessing transports while the other is deleting it.

For now just some notes:

• ShutdownSequence doesn't really need these:

  case DeviceState::Binding:
  case DeviceState::Connecting:
  case DeviceState::InitializingTask:
  case DeviceState::ResettingTask:
  case DeviceState::ResettingDevice:
  ChangeDeviceState(DeviceStateTransition::Auto);

  , since those auto-transition anyway.

• InterruptTransports is not needed on the auto-transition from ResettingDevice, but the auto transitions should be disambiguated.
• Access to transports should be made thread-safe. In this case main thread deletes the transports, while plugin thread (calling new transition callback) is accessing them.

[dennisklein]

So, one is accessing transports while the other is deleting it.

I guess we should synchronize those, shouldn't we?

[rbx]

So, one is accessing transports while the other is deleting it.

I guess we should synchronize those, shouldn't we?

Yeah. Also there is another race condition: