FairRootGroup / FairRoot

C++ simulation, reconstruction and analysis framework for particle physics experiments
http://fairroot.gsi.de
Other
57 stars 96 forks source link

`FairModule::AddSensitiveVolume` searches volume set twice #1495

Open dennisklein opened 6 months ago

dennisklein commented 6 months ago

https://github.com/FairRootGroup/FairRoot/commit/386912ebcc7877927980cbbf7ef46a32dddc3e4b introduced a double linear search of the volume on vList in FairModule::AddSensitiveVolume:

  1. search happens here
  2. search happens here, see FairVolumeList::addVolume

Possible fix involves changing the error behaviour of FairVolumeList::addVolume to return the failure to add to the caller, e.g. by returning a pointer to the added volume (which is nullptr in case of not adding it).