Closed karabowi closed 5 months ago
I would love to have the information that Geant4 11.2 introduced the deprecation also in the commit message.
Isn't that already in the commit message? I am probably missing something. What should be changed? Maybe suggest a new wording?
That said:
Do we know when G4FastStep::Propose…()
were introduced? Maybe we should raise the minimum version in our CMakeLists.txt
?
And finally: Can you please switch the target to the dev
branch, so that we then backport / fast-forward to all appropriate release branches?
Isn't that already in the commit message? I am probably missing something.
Not in the first version before the force push.
Yes, the force was only corresponding change in the commit message.
Still missing:
Do we know when
G4FastStep::Propose…()
were introduced? Maybe we should raise the minimum version in ourCMakeLists.txt
?
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Geant4 (geant4-11.2) deprecates functions G4FastStep::Set...(), and advices usage of corresponding G4FastStep::Propose...().
Replaced them all in FairFastSimModel.cxx.
Checklist: