search

FairRootGroup / FairRoot

C++ simulation, reconstruction and analysis framework for particle physics experiments
http://fairroot.gsi.de
Other
57 stars 96 forks source link

Fix various warnings #1516

Closed dennisklein closed 5 months ago

dennisklein commented 5 months ago

Fix #1501 and #1510

coderabbitai[bot] commented 5 months ago
Walkthrough ## Walkthrough This update primarily focuses on modernizing code, improving efficiency, and ensuring naming consistency across various files in the FairRoot project. Changes include updating copyright years, utilizing modern C++ features like `decltype` and range-based loops, refining logic in device handling, and standardizing naming conventions in data structures. ## Changes | File Path | Change Summary | |-----------|----------------| | `examples/MQ/.../FairMQExHistoDevice.cxx`
`examples/MQ/.../FairMQRunDevice.cxx` | Updated copyright year, included new headers, and modified loops for channel retrieval using FairMQ functions. | | `examples/MQ/.../*.cxx` | Updated loops to use modern C++ features like `decltype` and range-based loops for better performance and readability. | | `examples/MQ/.../*.h`
`examples/advanced/Tutorial3/MQ/.../*.h` | Updated variable and method names for consistency, e.g., changing `timestampError` to `timestamp_error`. | | `fairroot/.../FairMQ.h`
`fairroot/.../FairMQLmdSampler.h`
`fairroot/.../FairMQUnpacker.h` | Improved device channel access methods and error handling in FairMQ related files. | | `Jenkinsfile`
`cmake/private/Testlib.cmake`
`FairRoot_doxygen_test.cmake` | Adjustments in build configurations, CMake settings, and documentation paths. | | `examples/advanced/Tutorial3/MQ/data/*.fbs` | Renamed fields within FlatBuffers table definitions for clarity. | ## Possibly related issues - **FairRootGroup/FairRoot#1493**: The changes in CMake configurations and dependency handling in this PR might address some of the CMake warnings and errors mentioned in this issue. - **FairRootGroup/FairRoot#1418**: Although this PR does not directly address memory management issues in `FairRun` or `FairRootManager`, the overall improvements in code robustness and modernization could indirectly contribute to enhanced stability, which is a concern in this issue.
Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 66709b8e76ea9da67266a38ea9880bd0d59f4170 and e36e5e2b6b52d758e8906cd472e942c015ff5962.
Files selected for processing (21) * FairRoot_doxygen_test.cmake (2 hunks) * Jenkinsfile (5 hunks) * cmake/private/Testlib.cmake (2 hunks) * examples/MQ/histogramServer/FairMQExHistoDevice.cxx (3 hunks) * examples/MQ/pixelAlternative/src/devices/FairMQPixAltTaskProcessorBin.h (2 hunks) * examples/MQ/pixelDetector/src/devices/FairMQPixelFileSink.cxx (3 hunks) * examples/MQ/pixelDetector/src/devices/FairMQPixelFileSinkBin.cxx (2 hunks) * examples/MQ/pixelDetector/src/devices/FairMQPixelMerger.cxx (2 hunks) * examples/MQ/pixelDetector/src/devices/FairMQPixelTaskProcessor.h (2 hunks) * examples/MQ/pixelDetector/src/devices/FairMQRunDevice.cxx (4 hunks) * examples/MQ/pixelSimSplit/src/devices/FairMQChunkMerger.cxx (2 hunks) * examples/MQ/pixelSimSplit/src/devices/FairMQTransportDevice.cxx (2 hunks) * examples/MQ/serialization/processor.cxx (2 hunks) * examples/advanced/Tutorial3/MQ/data/PayloadDigi.fbs (1 hunks) * examples/advanced/Tutorial3/MQ/data/PayloadHit.fbs (1 hunks) * examples/advanced/Tutorial3/MQ/fileSink/FileSinkFlatBuffers.h (2 hunks) * examples/advanced/Tutorial3/MQ/processorTask/MQRecoTaskFlatBuffers.h (3 hunks) * examples/advanced/Tutorial3/MQ/samplerTask/DigiLoaderFlatBuffers.h (2 hunks) * fairroot/basemq/devices/FairMQLmdSampler.h (2 hunks) * fairroot/basemq/devices/FairMQUnpacker.h (3 hunks) * fairroot/fairmq/FairMQ.h (2 hunks)
Files skipped from review as they are similar to previous changes (20) * FairRoot_doxygen_test.cmake * Jenkinsfile * cmake/private/Testlib.cmake * examples/MQ/histogramServer/FairMQExHistoDevice.cxx * examples/MQ/pixelAlternative/src/devices/FairMQPixAltTaskProcessorBin.h * examples/MQ/pixelDetector/src/devices/FairMQPixelFileSink.cxx * examples/MQ/pixelDetector/src/devices/FairMQPixelFileSinkBin.cxx * examples/MQ/pixelDetector/src/devices/FairMQPixelMerger.cxx * examples/MQ/pixelDetector/src/devices/FairMQPixelTaskProcessor.h * examples/MQ/pixelDetector/src/devices/FairMQRunDevice.cxx * examples/MQ/pixelSimSplit/src/devices/FairMQChunkMerger.cxx * examples/MQ/serialization/processor.cxx * examples/advanced/Tutorial3/MQ/data/PayloadDigi.fbs * examples/advanced/Tutorial3/MQ/data/PayloadHit.fbs * examples/advanced/Tutorial3/MQ/fileSink/FileSinkFlatBuffers.h * examples/advanced/Tutorial3/MQ/processorTask/MQRecoTaskFlatBuffers.h * examples/advanced/Tutorial3/MQ/samplerTask/DigiLoaderFlatBuffers.h * fairroot/basemq/devices/FairMQLmdSampler.h * fairroot/basemq/devices/FairMQUnpacker.h * fairroot/fairmq/FairMQ.h
Additional comments not posted (2)
examples/MQ/pixelSimSplit/src/devices/FairMQTransportDevice.cxx (2)
`2-2`: Update the copyright year to 2024. --- `236-238`: Refactor the loop to use a range-based approach for iterating over `mParts`.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
dennisklein commented 5 months ago

I would prefer to leave the virtual operator< in FairTimeStamp, as well as the corresponding implementations in MyDigi and FairTestDetectorDigi. Would it be possible to add overload in the daughter classes?

I'll remove my commit regarding this from here and we can move it to a separate PR - made a separate issue to track this: #1519.