search

FairRootGroup / FairRoot

C++ simulation, reconstruction and analysis framework for particle physics experiments
http://fairroot.gsi.de
Other
57 stars 96 forks source link

workaround: Avoid geoloader memory issues #1518

Closed ChristianTackeGSI closed 5 months ago

ChristianTackeGSI commented 5 months ago

Not leaking fGeoLoader on FairRunSim seems to cause some memory issues (probbaly a double free/delete). Until we find it, let's leak the Geoloader, as before.

See: https://github.com/FairRootGroup/FairRoot/issues/1514 See: ede7137bd698df6ba9a6b4e6807e8225e68e121b

Checklist:

coderabbitai[bot] commented 5 months ago
Walkthrough ## Walkthrough The changes in this update encompass improvements in memory management and build pipeline efficiency. In `FairRunSim.cxx`, a comment highlights a memory leak issue related to `GeoLoader`, addressing potential stability concerns. Meanwhile, the `Jenkinsfile` now features conditional checkout logic based on file existence, simplifying job configurations for different environments and enhancing the overall pipeline setup. ## Changes | Files | Change Summary | |---------------------------|------------------------------------------------------------------------| | `.../steer/FairRunSim.cxx`, `Jenkinsfile` | Added a comment in `FairRunSim.cxx` highlighting a memory leak issue involving `GeoLoader`. Introduced conditional checkout logic in the `Jenkinsfile` based on file existence and reduced job configurations for different environments.| ## Possibly related issues - **FairRootGroup/FairRoot#1418**: The changes in this PR, by acknowledging memory management issues and introducing improvements in resource handling, indirectly support the objectives of resolving crashes and undefined behavior due to improper resource handling (like double deletion and initialization without use). The focus on memory leaks complements the broader goal of enhancing codebase stability and reliability, making this issue potentially related. The reasoning is that both the PR and this issue aim at improving memory management and preventing crashes.
Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between e36e5e2b6b52d758e8906cd472e942c015ff5962 and 67aaf5775deadd2ac5df00342dc3474d37a6b7ea.
Files selected for processing (3) * Jenkinsfile (3 hunks) * fairroot/base/steer/FairRunSim.cxx (1 hunks) * tests/ci/slurm-submit.sh (2 hunks)
Files not reviewed due to errors (2) * (no review received) * (no review received)
Additional Context Used
Shellcheck (2)
tests/ci/slurm-submit.sh (2)
[info] 64-64: Double quote to prevent globbing and word splitting. --- [info] 66-66: Double quote to prevent globbing and word splitting.
Additional comments not posted (3)
tests/ci/slurm-submit.sh (3)
`3-5`: The updated argument check and error message are clear and correctly enforce the new requirement for three arguments. --- `9-11`: Variable assignments for `type`, `label`, and `jobsh` are correctly updated to match the new argument structure. --- `30-31`: The switch case logic is correctly updated to check the `type` variable.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.