search

FairRootGroup / FairRoot

C++ simulation, reconstruction and analysis framework for particle physics experiments
http://fairroot.gsi.de
Other
57 stars 96 forks source link

`warning: 'virtual bool FairTimeStamp::operator<(const FairTimeStamp*) const' was hidden [-Woverloaded-virtual=]` #1519

Closed dennisklein closed 3 months ago

dennisklein commented 5 months ago

This warning appears on recent compiler versions in multiple places:

/fairroot/base/event/FairTimeStamp.h:77:18: warning: ‘virtual bool FairTimeStamp::operator<(const FairTimeStamp*) const’ was hidden [-Woverloaded-virtual=]
   77 |     virtual bool operator<(const FairTimeStamp* rValue) const { return GetTimeStamp() < rValue->GetTimeStamp(); }
      |                  ^~~~~~~~
/examples/advanced/Tutorial3/data/FairTestDetectorDigi.h:68:18: note:   by ‘virtual bool FairTestDetectorDigi::operator<(const FairTestDetectorDigi&) const’
   68 |     virtual bool operator<(const FairTestDetectorDigi& myDigi) const
      |                  ^~~~~~~~

The issue was discussed in our group meeting on 15th April 2024 and assigned to @TobiasStockmanns for review/advice for now.

For reference: A previous attempt to resolve the issue was rejected/commented by @karabowi