search

FairRootGroup / FairRoot

C++ simulation, reconstruction and analysis framework for particle physics experiments
http://fairroot.gsi.de
Other
57 stars 96 forks source link

fix: Avoid casting to void #1528

Closed ChristianTackeGSI closed 4 months ago

ChristianTackeGSI commented 4 months ago

Instead of casting to void to ignore a return value, use std::ignore.

See: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-casts

Checklist:

coderabbitai[bot] commented 4 months ago
Walkthrough ## Walkthrough The changes across various files in the FairRoot project involve updating the copyright year to 2024 and removing the explicit `void` keyword from method parameters and destructors. These modifications aim to streamline the syntax and adhere to modern C++ conventions, enhancing code clarity without fundamentally altering the core functionality. ## Changes | Files | Changes | |-------|---------| | `examples/MQ/pixelDetector/src/.../PixelGeoPar.cxx`
`examples/advanced/.../FairTestDetectorGeoPar.cxx`
`examples/advanced/propagator/src/.../FairTutPropGeoPar.cxx`
`examples/common/passive/.../FairGeoPassivePar.*`
`examples/simulation/Tutorial1/src/.../FairTutorialDet1GeoPar.*`
`examples/simulation/Tutorial2/src/.../FairTutorialDet2GeoPar.*`
`examples/simulation/Tutorial4/src/param/.../FairTutorialDet4GeoPar.*`
`examples/simulation/Tutorial4/src/param/.../FairTutorialDet4MisalignPar.*`
`fairroot/base/sim/.../FairBaseParSet.cxx`
`fairroot/base/sim/.../FairGeoParSet.cxx`
`fairroot/base/steer/.../FairRunSim.cxx`
`fairroot/datamatch/.../FairMCObject.h`
`fairroot/datamatch/.../FairMCResult.h`
`fairroot/datamatch/.../FairMCStage.h`
`fairroot/geobase/.../FairGeoMatrix.*`
`fairroot/geobase/.../FairGeoSet.h`
`fairroot/geobase/.../FairGeoTransform.*`
`fairroot/parbase/.../FairRtdbRun.h`
`fairroot/parbase/.../FairRuntimeDb.*`
`templates/NewDetector_root_containers/.../NewDetectorGeoPar.*`
`templates/NewDetector_stl_containers/.../NewDetectorGeoPar.*`
`templates/NewParameterContainer/.../NewParameterContainer.*`
`templates/project_root_containers/NewDetector/.../NewDetectorGeoPar.*`
`templates/project_stl_containers/NewDetector/.../NewDetectorGeoPar.*` | Updated copyright year to 2024 and removed `void` from method parameters and destructors. | ## Possibly related issues - **FairRootGroup/FairRoot#1418**: While this PR focuses on syntactic updates, the stability improvements through clearer and more consistent code might indirectly contribute to reducing unexpected behaviors, such as those mentioned in the issue related to memory management and crashes. However, direct links to memory management fixes are not evident in this PR.
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 54f1d2836726b96ff4647541dd427aa50a3ba48e and f87c3bb83cdd06855a4b94e115692f13dd592d25.
Files selected for processing (37) * examples/MQ/pixelDetector/src/PixelGeoPar.cxx (2 hunks) * examples/advanced/Tutorial3/simulation/FairTestDetectorGeoPar.cxx (2 hunks) * examples/advanced/propagator/src/FairTutPropGeoPar.cxx (2 hunks) * examples/common/passive/FairGeoPassivePar.cxx (2 hunks) * examples/common/passive/FairGeoPassivePar.h (2 hunks) * examples/simulation/Tutorial1/src/FairTutorialDet1GeoPar.cxx (2 hunks) * examples/simulation/Tutorial1/src/FairTutorialDet1GeoPar.h (2 hunks) * examples/simulation/Tutorial2/src/FairTutorialDet2GeoPar.cxx (2 hunks) * examples/simulation/Tutorial2/src/FairTutorialDet2GeoPar.h (2 hunks) * examples/simulation/Tutorial4/src/param/FairTutorialDet4GeoPar.cxx (2 hunks) * examples/simulation/Tutorial4/src/param/FairTutorialDet4GeoPar.h (2 hunks) * examples/simulation/Tutorial4/src/param/FairTutorialDet4MisalignPar.cxx (2 hunks) * examples/simulation/Tutorial4/src/param/FairTutorialDet4MisalignPar.h (2 hunks) * fairroot/base/sim/FairBaseParSet.cxx (2 hunks) * fairroot/base/sim/FairGeoParSet.cxx (2 hunks) * fairroot/base/steer/FairRunSim.cxx (2 hunks) * fairroot/datamatch/FairMCObject.h (2 hunks) * fairroot/datamatch/FairMCResult.h (2 hunks) * fairroot/datamatch/FairMCStage.h (2 hunks) * fairroot/geobase/FairGeoMatrix.cxx (3 hunks) * fairroot/geobase/FairGeoMatrix.h (2 hunks) * fairroot/geobase/FairGeoSet.h (2 hunks) * fairroot/geobase/FairGeoTransform.cxx (2 hunks) * fairroot/geobase/FairGeoTransform.h (2 hunks) * fairroot/parbase/FairRtdbRun.h (3 hunks) * fairroot/parbase/FairRuntimeDb.cxx (5 hunks) * fairroot/parbase/FairRuntimeDb.h (4 hunks) * templates/NewDetector_root_containers/NewDetectorGeoPar.cxx (2 hunks) * templates/NewDetector_root_containers/NewDetectorGeoPar.h (2 hunks) * templates/NewDetector_stl_containers/NewDetectorGeoPar.cxx (2 hunks) * templates/NewDetector_stl_containers/NewDetectorGeoPar.h (2 hunks) * templates/NewParameterContainer/NewParameterContainer.cxx (2 hunks) * templates/NewParameterContainer/NewParameterContainer.h (2 hunks) * templates/project_root_containers/NewDetector/NewDetectorGeoPar.cxx (2 hunks) * templates/project_root_containers/NewDetector/NewDetectorGeoPar.h (2 hunks) * templates/project_stl_containers/NewDetector/NewDetectorGeoPar.cxx (2 hunks) * templates/project_stl_containers/NewDetector/NewDetectorGeoPar.h (2 hunks)
Files skipped from review as they are similar to previous changes (37) * examples/MQ/pixelDetector/src/PixelGeoPar.cxx * examples/advanced/Tutorial3/simulation/FairTestDetectorGeoPar.cxx * examples/advanced/propagator/src/FairTutPropGeoPar.cxx * examples/common/passive/FairGeoPassivePar.cxx * examples/common/passive/FairGeoPassivePar.h * examples/simulation/Tutorial1/src/FairTutorialDet1GeoPar.cxx * examples/simulation/Tutorial1/src/FairTutorialDet1GeoPar.h * examples/simulation/Tutorial2/src/FairTutorialDet2GeoPar.cxx * examples/simulation/Tutorial2/src/FairTutorialDet2GeoPar.h * examples/simulation/Tutorial4/src/param/FairTutorialDet4GeoPar.cxx * examples/simulation/Tutorial4/src/param/FairTutorialDet4GeoPar.h * examples/simulation/Tutorial4/src/param/FairTutorialDet4MisalignPar.cxx * examples/simulation/Tutorial4/src/param/FairTutorialDet4MisalignPar.h * fairroot/base/sim/FairBaseParSet.cxx * fairroot/base/sim/FairGeoParSet.cxx * fairroot/base/steer/FairRunSim.cxx * fairroot/datamatch/FairMCObject.h * fairroot/datamatch/FairMCResult.h * fairroot/datamatch/FairMCStage.h * fairroot/geobase/FairGeoMatrix.cxx * fairroot/geobase/FairGeoMatrix.h * fairroot/geobase/FairGeoSet.h * fairroot/geobase/FairGeoTransform.cxx * fairroot/geobase/FairGeoTransform.h * fairroot/parbase/FairRtdbRun.h * fairroot/parbase/FairRuntimeDb.cxx * fairroot/parbase/FairRuntimeDb.h * templates/NewDetector_root_containers/NewDetectorGeoPar.cxx * templates/NewDetector_root_containers/NewDetectorGeoPar.h * templates/NewDetector_stl_containers/NewDetectorGeoPar.cxx * templates/NewDetector_stl_containers/NewDetectorGeoPar.h * templates/NewParameterContainer/NewParameterContainer.cxx * templates/NewParameterContainer/NewParameterContainer.h * templates/project_root_containers/NewDetector/NewDetectorGeoPar.cxx * templates/project_root_containers/NewDetector/NewDetectorGeoPar.h * templates/project_stl_containers/NewDetector/NewDetectorGeoPar.cxx * templates/project_stl_containers/NewDetector/NewDetectorGeoPar.h
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ChristianTackeGSI commented 4 months ago

Do we want to add ES.48 as adopted rule in CONTRIBUTING.md as well?

IMHO yes.

We (partly) already did by adopting cppcoreguidelines-pro-type-cstyle-cast in clang-tidy.

Should I add it to CONTRIBUTING in this PR?

dennisklein commented 4 months ago

Do we want to add ES.48 as adopted rule in CONTRIBUTING.md as well?

IMHO yes.

We (partly) already did by adopting cppcoreguidelines-pro-type-cstyle-cast in clang-tidy.

Should I add it to CONTRIBUTING in this PR?

As you wish, but before we merge it, let's make it a quick point on next group meeting.

ChristianTackeGSI commented 4 months ago

As you wish, but before we merge it, let's make it a quick point on next group meeting.

dennisklein commented 4 months ago
  • Added ES.48 to Group Meeting (can you add it to CONTRIBUTING.md, if it's approved, please?)

will do, thx!