Faire / mjml-react

React component library to generate the HTML emails on the fly
https://www.npmjs.com/package/@faire/mjml-react
MIT License
375 stars 16 forks source link

feat(react): upgrade dev dependency to react 18 #119

Closed emmclaughlin closed 2 months ago

emmclaughlin commented 2 months ago

Update regarding https://github.com/Faire/mjml-react/issues/115 to ensure mjml-react is compatibile with React 19

Part of React 19 upgrade guide is to first upgrade to React 18.3 to help identify any issues.

The upgrade to react 18.3 did not cause any changes when generating or building the mjml-react files. It did however cause some type errors on a few of the extensions. This was easily solved by explicitly defining the children prop.

React itself is still a peer dependency of mjml-react, and this update should be backwards compatible