Closed IanEdington closed 2 years ago
@iduuck made some pretty sweet types in his internal version of mjml-react. PercentageMatrix, PixelMatrix and EmMatrix would add a lot of value to our generated components.
PercentageMatrix
PixelMatrix
EmMatrix
https://github.com/ksv-vc/postbote/blob/e0234fdd7d4b4aa507c9dc82e7ef8c6fbbfecdb1/packages/mjml-react/lib/index.ts#L6-L28
PercentageMatrix, PixelMatrix and EmMatrix would have to be added and exported from a production file somewhere, possibly in utils.ts: https://github.com/Faire/mjml-react/blob/383996dc47415fcaa93e36d892e8e18ca78fc609/src/utils.tsx
They would need to be added to the generated components hereish: https://github.com/Faire/mjml-react/blob/383996dc47415fcaa93e36d892e8e18ca78fc609/scripts/generate-mjml-react.ts#L101-L106
@iduuck made some pretty sweet types in his internal version of mjml-react.
PercentageMatrix,PixelMatrixandEmMatrixwould add a lot of value to our generated components.https://github.com/ksv-vc/postbote/blob/e0234fdd7d4b4aa507c9dc82e7ef8c6fbbfecdb1/packages/mjml-react/lib/index.ts#L6-L28
PercentageMatrix,PixelMatrixandEmMatrixwould have to be added and exported from a production file somewhere, possibly in utils.ts: https://github.com/Faire/mjml-react/blob/383996dc47415fcaa93e36d892e8e18ca78fc609/src/utils.tsxThey would need to be added to the generated components hereish: https://github.com/Faire/mjml-react/blob/383996dc47415fcaa93e36d892e8e18ca78fc609/scripts/generate-mjml-react.ts#L101-L106