Faire / mjml-react

React component library to generate the HTML emails on the fly
https://www.npmjs.com/package/@faire/mjml-react
MIT License
375 stars 16 forks source link

`MjmlSelector` and `MjmlHtmlAttribute` were not migrated to v3 #74

Closed vongb closed 1 year ago

vongb commented 1 year ago

Hey team,

I'm running into an issue when updating from 2.1.4 to 3.0.0. It looks like MjmlHtmlAttribute(singular) and MjmlSelector were removed and not migrated to typescript in #17. Only MjmlHtmlAttributes (plural) is being exported but the selector and html attribute are required to be used inside the HTML attributes in the mjml docs.

Is there a way to have the MjmlHtmlAttributes in the same way without using the selector and HTML attribute that I'm missing?

For context, I need to mark certain elements as a universal link for SendGrid. https://sendgrid.com/docs/ui/sending-email/universal-links/#flagging-your-universal-links

Let me know if I've missed anything. 😄 Thanks for your help in advance!

IanEdington commented 1 year ago

Hi @vongb Thanks for the heads up. These components weren't imported automatically because they aren't created as components in mjml

I've added them manually in #75

vongb commented 1 year ago

Awesome, thank you!!

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

IanEdington commented 1 year ago

Hi @vongb, can you try it out and see that it's working as expected for your use case? 🙏

vongb commented 1 year ago

@IanEdington works great thanks!!!