Faire / mjml-react

React component library to generate the HTML emails on the fly
https://www.npmjs.com/package/@faire/mjml-react
MIT License
375 stars 16 forks source link

Invalid `textAlign` type #82

Closed nezort11 closed 1 year ago

nezort11 commented 1 year ago
<MjmlSection textAlign="start">
   ...
</MjmlSection>

With validationLevel: "strict" gives:

Error: ValidationError: 
 ... (mj-section) — Attribute text-align has invalid value: start for type Enum, only accepts left, center, right

*Probably start/end throw ValidationError for most client compatibility: https://caniuse.com/mdn-css_properties_text-align_flow_relative_values_start_and_end

IanEdington commented 1 year ago

Thanks for reporting and putting in a fix @nezort11!!

This seems like it should have been picked up by the component import from mjml. It will have to changed in the generate-mjml script. There's probably some discovery we'll have to do to figure out why this isn't working as expected. We'll try to prioritize this ticket

IanEdington commented 1 year ago

fixed by #85