search

Faire / mjml-react

React component library to generate the HTML emails on the fly
https://www.npmjs.com/package/@faire/mjml-react
MIT License
375 stars 16 forks source link

chore(deployment): Change the release branch names to `alpha` and `beta` #86

Closed IanEdington closed 1 year ago

IanEdington commented 1 year ago

The tags on npm have main in the currently. By using alpha and beta as the branch names this should remove the "main" from the names

IanEdington commented 1 year ago

This looks reasonable, but the main reason for using main-beta and main-alpha is that main* are protected branches. Do we have the protection setup for alpha and beta before merging this?

I simplified the rules quite a bit:

  1. blocking the ability to target these branches to merge (should target main-v4, main or main-v2 IMO)
  2. only allow pushing to these branches if you're an admin

The workflow would be. Make a change, put up a PR, get it approved & merged. If you want to deploy to alpha or beta, force push to those branches.

As I'm writing this out though I wonder if it would be better to remove 'alpha' and 'beta' in favour of targeting main-v4, main or main-v2. The package.json config should allow all three 'main' branches to be released to their correct channels.

Screenshot 2023-02-02 at 11 16 26 AM

IanEdington commented 1 year ago

I'm going to close this for now since I haven't been able to dedicate time towards it. I'll re-open in the future when we start working on it again