Overriding configurations for alert thresholds with annotations does not work

sylon23 commented 3 years ago

Context

Based on the documentation here overriding alert configurations with the field "threshold-critical" does not work.

Process

Created a custom monitor (apdex-alert) in configuration file
Added annotations to override monitor name, query, and message in a Kubernetes deployment and there are no logged errors for these.
Added annotation to override alert threshold in the same deployment- "astro.fairwinds.com/override.apdex-alert.threshold-critical: 0.80"

Expected Result

Monitor is created
Newly created monitor reflects the new values

Current Result

Monitor is not created.
The following can be seen in the logs

time="2021-06-02T15:55:58Z" level=warning msg="override provided does mot match any monitor fields. provided field: threshold-critical"

Please help fix or suggest any necessary modifications.

lucasreed commented 3 years ago

Thanks for bringing this to our attention! We will do our best to take look at this ASAP but our time has been a bit limited on this project. Thanks for being understanding!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

FairwindsOps / astro