FairwindsOps / pentagon

A framework for building repeatable, containerized, cloud-based infrastructure as code with Kubernetes.
https://www.reactiveops.com
Apache License 2.0
183 stars 25 forks source link

Better handling of aws secrets when adding a new inventory #123

Closed sudermanjr closed 5 years ago

sudermanjr commented 6 years ago

Currently, the syntax for adding a new inventory requires this:

pentagon add inventory -Dtype=aws -Dname=prod -Daws_access_key=REDACTED -Daws_secret_key=REDACTED -D=aws_default_region=us-east-1

This is confusing since the start project syntax is:

pentagon add inventory -Dtype=aws -Dname=prod -Daws-access-key=REDACTED -Daws-secret-key=REDACTED -D=aws-default-region=us-east-1

It would be preferred to use the same syntax (dashes) for both.

ejether commented 6 years ago

Those look exactly the same to me. Is there a difference I'm not spotting?

sudermanjr commented 6 years ago

Underscores vs Dashes in the parameter names.

ejether commented 6 years ago

Ah, yes. 🤦‍♀️