Closed endzyme closed 6 years ago
Looks good to me. I think we should add a note to Changelog and discuss a migration for this.
@ejether Is there something else I need to do for the cla license check in GitHub?
If you click on details and click through, you should be able to sign the CLA with your github creds. I also realize we never ended up discussing the migration format, which we should do.
I noticed that the original vars.yaml was created with the
default
name but someone later copy pasted the vars.yaml file into other inventory folders. This resulted in kubeconfig context always creating an./inventory/default/
folder when there were only/inventory/production/
and/inventory/working/
folders. This would also bleed changes between differentpentagon_workon
environments when you usekubectx
orkubens
to change context information (because both envs would point at one KUBECONFIG).This change also fixes an issue I had hit a few times where I would
pentagon_workon <client>
and it would make a new file in the repo and thus I would have a dirty git status on a file that should never be committed to the repository.