search

FairwindsOps / pentagon

A framework for building repeatable, containerized, cloud-based infrastructure as code with Kubernetes.
https://www.reactiveops.com
Apache License 2.0
183 stars 25 forks source link

Adding migration for runc hook #188

Closed sudermanjr closed 5 years ago

sudermanjr commented 5 years ago

Adds the hook if it does not exist. Modifies it to newest if it is the old one.

sudermanjr commented 5 years ago

Strange, while testing this it does the updating of the hook properly in some places and not in others.

ejether commented 5 years ago

I rebased your branch so it got the pipeline fixes that we were working on yesterday.

sudermanjr commented 5 years ago

@ejether Do I need to change versions on this?

GIT master: Already up to date.
2019-03-11 09:54:22 root[67405]     INFO Pentagon Version: 3.1.0
2019-03-11 09:54:22 root[67405]     INFO Starting Repository Version: 2.7.3
2019-03-11 09:54:22 root[67405]     INFO No Migrations to run.
2019-03-11 09:54:22 root[67405]     INFO Installed Version > Repository Version.
2019-03-11 09:54:22 root[67405]     INFO  Use `pentagon migrate --yes` to update Repository
ejether commented 5 years ago

https://github.com/reactiveops/pentagon/blob/master/pentagon/migration/__init__.py#L60

Yes, I think I led you astray. The migration name should be pentagon/migration/migrations/migration_2_7_3.py. The migration finding check is picky like that.

sudermanjr commented 5 years ago

That did the trick. If tests pass I'll ship this.