search

FairwindsOps / pentagon

A framework for building repeatable, containerized, cloud-based infrastructure as code with Kubernetes.
https://www.reactiveops.com
Apache License 2.0
183 stars 25 forks source link

Ejether/minor fixes #189

Closed ejether closed 5 years ago

ejether commented 5 years ago

Some minor things I noticed and wanted to enhance.

ejether commented 5 years ago

I don't know a way around accepting the broken build. Since the passing the migration test requires the --no-prompt and this PR adds it. I guess, in order for these to pass, we'll have to remove the test, push a version with --no-prompt, release it, then add the migration test back in.

endzyme commented 5 years ago

@ejether you can add yes | <pentagon commands> which will stdout to stdin y+Enter for all command reads

Sorry edit: We should probably detect if the runenv is a tty or non-interactive. If non-interactive - don't ask acceptance. (https://rosettacode.org/wiki/Check_input_device_is_a_terminal#Python)

ejether commented 5 years ago

Ah! Why didn't I think of that. I'll give it a shot on Circle, then back out the --prompt stuff if it works.