search

FairwindsOps / pentagon

A framework for building repeatable, containerized, cloud-based infrastructure as code with Kubernetes.
https://www.reactiveops.com
Apache License 2.0
183 stars 25 forks source link

Fix node_count default #194

Closed rbren closed 5 years ago

rbren commented 5 years ago

Was working with EJ and noticed that after running pentagon start-project and runner cluster_configure, the file inventory/default/clusters/$cluster/cluster-config/nodes.yml had three InstanceGroups with maxSize=minSize=3, resulting in a total of 9 nodes (3 per subnet), rather than the desired 3 nodes (1 per subnet). From what I understand, we recently switched from having one IG spread across 3 subnets, to one IG per subnet - guessing this is an artifact of that change.

Changing this default sets ig_max_size=ig_min_size=1 in inventory/default/clusters/$cluster/vars.yml, which results in maxSize=minSize=1 in nodes.yml.

Let me know if there's a better way to fix this.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

ejether commented 5 years ago

Agreed, but I think that will be a more substantial change. @bobby-brennan woud you drop a note in the CHANGELOG.md about the change?

rbren commented 5 years ago

Done - bumped version to 3.1.2 as well.