Dependency updates fail with Git-based chart

rbren commented 4 days ago

What happened?

Tried to run this course

schema: v2
namespace: all-hands-system
repositories:
  litellm:
    git: https://github.com/BerriAI/litellm
    path: deploy/charts
namespace_management:
  default:
    settings:
      overwrite: false
releases:
  - name: litellm
    repository: litellm
    chart: litellm-helm
    version: 274bf3e

This results in an error that doesn't really look like an error

error with release litellm: error running helm dependency update: Pulled: registry-1.docker.io/bitnamicharts/postgresql:16.0.4

I get these logs with --v=5 (--v=10 killed GitHub actions--lmk if there's a better log level)

Cloning into '/home/runner/.cache/helm/repository/github_com_BerriAI_litellm_goreckoner'...
Saving 2 charts
Downloading postgresql from repo oci://registry-1.docker.io/bitnamicharts
Pulled: registry-1.docker.io/bitnamicharts/postgresql:14.3.1
Digest: sha256:d1[53](https://github.com/All-Hands-AI/infra/actions/runs/11446965234/job/31847280227?pr=165#step:9:54)06deb733b717bdf71d68c5670b3db0d061693a4e18c93d2ce842a09dcf36
Downloading redis from repo oci://registry-1.docker.io/bitnamicharts
Pulled: registry-1.docker.io/bitnamicharts/redis:18.19.1
Digest: sha256:1e9f07f57b3825529247b3c3b63df60ba7d7c032d9512070ce8973df39b05ce3
Deleting outdated charts
/home/runner/work/infra/infra
I1021 19:11:46.297875    1775 validation.go:45] colorize output: true
I1021 19:11:46.298442    1775 course.go:515] setting the default namespace of all-hands-system on release litellm
I1021 19:11:46.298489    1775 course.go:526] no default repository set - skipping filling out defaults
I1021 19:11:46.298[54](https://github.com/All-Hands-AI/infra/actions/runs/11446965234/job/31847280227?pr=165#step:9:55)0    1775 namespace.go:23] using default namespace management for release: litellm
I1021 19:11:46.300225    1775 helm.go:40] found helm at /usr/local/bin/helm
I1021 19:11:46.300916    1775 client.go:142] no minimum helm version found, assuming okay
I1021 19:11:46.301433    1775 client.go:164] checking current reckoner version: 6.0.0
I1021 19:11:46.301[56](https://github.com/All-Hands-AI/infra/actions/runs/11446965234/job/31847280227?pr=165#step:9:57)2    1775 client.go:166] no minimum reckoner version found, assuming okay
I1021 19:12:04.287685    1775 helm.go:107] updating chart dependencies for /home/runner/.cache/helm/repository/https_github_com_BerriAI_litellm_goreckoner/deploy/charts/litellm-helm
error with release litellm: error running helm dependency update: Pulled: registry-1.docker.io/bitnamicharts/postgresql:16.0.4
Digest: sha256:5b[59](https://github.com/All-Hands-AI/infra/actions/runs/11446965234/job/31847280227?pr=165#step:9:60)5b6cbf6c82d3bb35fb7d4bd32a7b668d7438b127152a5b0de189828699c5
Pulled: registry-1.docker.io/bitnamicharts/redis:20.2.1
Digest: sha256:c8a24ee04cd1e029e7ec9c223a59da0b067ed64804177927b0b51eee8117272d
, continuing.
error running helm dependency update: Pulled: registry-1.docker.io/bitnamicharts/postgresql:16.0.4
Digest: sha256:5b595b6cbf6c82d3bb35fb7d4bd32a7b668d7438b127152a5b0de189828699c5
Pulled: registry-1.docker.io/bitnamicharts/redis:20.2.1
Digest: sha256:c8a24ee04cd1e029e7ec9c223a59da0b067ed[64](https://github.com/All-Hands-AI/infra/actions/runs/11446965234/job/31847280227?pr=165#step:9:65)804177927b0b51eee8117272d

What did you expect to happen?

successful install

How can we reproduce this?

see above

Version

6.0.0

Search

[X] I did search for other open and closed issues before opening this.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Additional context

No response

sudermanjr commented 4 days ago

Since it pulls the other charts just fine (redis for example), I would be curious to know what the difference is with postgres, and if this chart works outside reckoner.

Edit: maybe that's not what's happening, but it seems like maybe we're not handling OCI charts correctly. Likely a helm update or the change to helm dep build will help

sudermanjr commented 4 days ago

Also, not sure why you would use a git-based chart rather than their OCI registry? oci://ghcr.io/berriai/litellm-helm

FairwindsOps / reckoner