removing unnecessery return statements,changing some clone methods et…

FaisalBinAhmed / MVGFahrinfo

Get up-to-date departure times for Munich public transport in your terminal.

https://crates.io/crates/mvgfahrinfo

MIT License

77 stars 4 forks source link

removing unnecessery return statements,changing some clone methods et… #2

Closed bq-wrongway closed 11 months ago

bq-wrongway commented 11 months ago

…c. (suggest using cargo clippy --all -- -D warnings --verbose) to deal with format errors

FaisalBinAhmed commented 11 months ago

Hi thanks for opening up the PR. @bq-wrongway 👏

I actually put those return statements on purpose. I am personally not a fan of implicit return. But I am willing to change those to be more idimotically rust. :)

Also, could you remove the .idea related files from the PR. Make sure to put the folder in .gitignore

bq-wrongway commented 11 months ago

Hey, i removed .idea file , sorry about that. Regarding implicit returns, its your choice, i think its good habit to get used to, since its idiomatic way.