FaisalUmair / udemy-downloader-gui

A desktop application for downloading Udemy Courses
MIT License
6.14k stars 1.73k forks source link

Subtitles in random languages #101

Closed FrederickGIT closed 6 years ago

FrederickGIT commented 6 years ago

Whenever it downloads subtitles, it seems to pick a random language - English, Spanish or Portuguese, in the same course different videos will have different languages.

I can't use that, and I need subtitles. In English.

FaisalUmair commented 6 years ago

The option to select subtitles will be available in next release. It got delayed by couple of recent login issues.

FrederickGIT commented 6 years ago

Thanks, I hope it comes out soon enough

FaisalUmair commented 6 years ago

I have added this feature in v1.6.0. Download and provide feedback.

FrederickGIT commented 6 years ago

It seems to work. Every subtitle file I have checked seems to be in English and working well.

Just in CASE a future Udemy upload breaks something in this feature, or possibly occasional glitches idk, I would suggest that you add a way to manually select/download subtitles for individual videos

Otherwise, great work and thank you a lot for having taken the time to do this

FaisalUmair commented 6 years ago

Do you mean asking the user to choose available subtile for each lecture like we ask at beginning of download? If yes, don't you think the user will have to watch the course download lecture by lecture as after each lecture it will require input from user?

And yes for now, I have added a label that shows in how many lectures does the subtitle occur. Which will help the user choose the best option and for those lecture which do not include the selected subtitle, an alternative one would be downloaded.

FrederickGIT commented 6 years ago

Basically what you said, but only as an optional feature to be used in case of "emergency" should the language selection get the wrong subtitles for whatever reason. Otherwise everything would be left as it currently is.

It was just a suggestion in case something breaks.