search

Faithful-Resource-Pack / API

A public API for Faithful Resource Pack textures, add-ons and more
https://api.faithfulpack.net
GNU Affero General Public License v3.0
0 stars 0 forks source link

Deprecate v1 API and switch our internal JSONs to match the v2 formatting. #32

Closed 3vorp closed 10 months ago

3vorp commented 1 year ago

As far as I can tell, only the Jekyll site currently uses the v1 API. As a result, there's no real reason to support it anymore given the site is to be replaced soon anyways. In addition, the only place that appears to use the raw Firestorm collections directly without the API is small parts of the webapp, which could pretty easily be replaced.

This would allow us to switch the raw json collections in the database to match the v2 formatting directly — currently the v2 API uses a bunch of mapping tools to switch formats on the fly. This would make backups easier too since what you write actually goes in as-is to the DB

TheRolfFR commented 1 year ago

I would still recommend to create and modify V2 endpoints so that the website uses them and doesn't break. New website has no date yet and is far from being totally finished

3vorp commented 1 year ago

yeah that's what I was thinking as well — this is more of a long-term issue anyways since everything would still work without it

3vorp commented 10 months ago

Update: since nothing else besides the API directly relies on Firestorm, I feel like we can proceed with migrating all data to the modern v2 format.

3vorp commented 10 months ago

completed with a06b34255cf196046da6273ae20e14f7350b471d woooo