search

Faithful-Resource-Pack / App

The official web application for the Faithful Website.
https://webapp.faithfulpack.net/
GNU Affero General Public License v3.0
1 stars 6 forks source link

Do not truncate texture paths in the use/path editors #107

Closed Pomi108 closed 1 year ago

Pomi108 commented 1 year ago

What happened?

The web app always trims off the assets/minecraft/ from all Java paths, even though that prefix is still present in the database. Since the prefix is needed for the path to work correctly, truncating the paths in the web app only causes issues. Luckily this only seems to be a display issue, since pasting the full path when creating it adds it to the database properly.

To reproduce

  1. Go to the Textures tab
  2. Search for a texture
  3. Press the edit button
  4. Edit the use
  5. See that the paths are being truncated

Screenshot(s)

obrazek obrazek

Browser name and version

Not relevant.

Logs

No response

Notes

No response

Pomi108 commented 1 year ago

The path is still truncated in the path editor obrazek

TheRolfFR commented 1 year ago

This how it is stored in db image More details here https://github.com/Faithful-Resource-Pack/App/issues/92#issuecomment-1214142494 No modification is made.

Pomi108 commented 1 year ago

oh, right. forgot juknum did that

TheRolfFR commented 1 year ago

What should we do them for this issue?

Pomi108 commented 1 year ago

Nothing for now I guess – what the path editor displays now is correct, after all When this issue is fixed and the database format changed, I think we'll have achieved the ideal outcome

3vorp commented 1 year ago

fixed with recent api changes