Faithful-Resource-Pack / App

The official web application for the Faithful Website.
https://webapp.faithfulpack.net/
GNU Affero General Public License v3.0
1 stars 6 forks source link

[Feature] Preparation for Overlay Compatibility #110

Closed Pomi108 closed 10 months ago

Pomi108 commented 1 year ago

This issue goes in tandem with CompliBot#249, Database#4, and API#30

Since 23w31a Minecraft allows resource packs to work with multiple pack formats at once. Overlays are a way for packs to provide files that need to be changed for them to work with a specific pack format without overwriting the base files of the pack. (More info in the linked minecraft.net article.)

While our software is technically mostly compatible with overlays aready, I am proposing some changes that, if implemented, would make the experience friendlier to end users and ensure nothing breaks in the future.

Path Truncating

Affects: Gallery texture menu

Overlay paths (i.e. Java paths only in version java-latest that don't start with assets/) should have their paths trimmed in the gallery texture menu to remove the overlay prefix (1.21/ for example) so that only the vanilla path starting with assets/ is visible to the end user. This should not be the case for admin tools! The full paths need to be visible there.

Display Versions

Affects: Gallery texture menu, texture creation modal, path edit modal

The existing menus and editors in the web app should be modified to allow for display version editing, and show display versions instead of regular versions where appropriate. java-latest should also be made the default version for Java paths in the texture creation modal, as the vast majority of future new textures will be assigned to this version internally.

3vorp commented 10 months ago

After months of discussion, many, many potential solutions, and a lot of thought for edge cases, we've decided not to implement overlays into Faithful.

The main reasons include: