search

Faithful-Resource-Pack / App

The official web application for the Faithful Website.
https://webapp.faithfulpack.net/
GNU Affero General Public License v3.0
1 stars 6 forks source link

[Feature] Add frontend for merging textures #124

Open 3vorp opened 8 months ago

3vorp commented 8 months ago

Is your feature request related to a problem?

There's no good way to merge two textures currently without manually copying over everything.

Describe the feature you'd like

The API backend for merging two textures has been done for some time (PUT /textures/merge/{add_id}/{remove_id}), but there's no frontend for actually doing it with a GUI. I'm not sure what the best way to do this would be — I'm thinking either a button on the texture modal next to the save button or a button in the texture search next to the edit/delete buttons could bring up a modal that lets you enter a texture ID to be merged in and deleted.

Screenshot(s)

image image

Notes

No response

TheRolfFR commented 8 months ago

Don't merge this one without I give a personal touch to the code. Please make a PR for it.

An icon button on the texture item is a better solution, because we wouldn't have to update the edit modal after the merge.

The texture to remove could be something more visual with a searchbox and an item preview.

The "texture to add" is terrible description, I would call it "Destination texture", and I would like the input to be disabled.

I would also add a confirmation sentence to avoid misclicks.

More generally, a little more visuals would help preview the changes.

TheRolfFR commented 3 months ago

Did you do something on this yet @3vorp?

3vorp commented 3 months ago

No, but I've also built the backend for the same feature for user merging and ID changing so whatever UI we come with here should probably be used for the user page.