[Long-term] CompliBot v4 "rewrite"

[3vorp]

While CompliBot v2 (the slash command bot) has been working decently well, internally, it's a bit of a mess to put it mildly. This is not planned to be a full rewrite by any means, since pretty much all the command function code works fine as is — I'm mostly focused on the internals.

Here's a general checklist of what I want to accomplish with this "rewrite".

• [x] Update to discord.js v14. That's literally it.
• [x] Completely remove settings.json from the bot.
  • I know I literally just added it to solve the problem of config.json but turns out ES6 modules are statically created and therefore cannot have their cache purged like the submission bot.
  • Therefore, I cannot dynamically ever refresh the JSON meaning that you have to just deal with fetching it every time.
  • However, the API should facilitate this since you can query specific properties and just fetch those directly with Axios.
• [x] Redo feedback system to match the recent submission bot rework of that command.
  • This can additionally be crossposted to the current feedback channels if need be, but this should bring much better organization and searchability to the feedback system, which currently results in a lot of stuff either getting forgotten or buried.
• [x] Simplify and rework command handler completely.
  • Much of the command handler was built for moderation and with old Discord systems in mind.
  • In recent times, most of this has been simplified and now can be consolidated down into a few helper functions from the current excessively huge loader.
• [x] Improve string loading and remove all the unused strings.
  • This is another remnant of a much older CompliBot that's never been fully reworked.
  • The string system as it stands is mostly unused, difficult to edit, even more difficult to understand, and many originally ephemeral messages aren't even ephemeral anymore.
  • I've made some concepts before on how we could potentially rework it while minimizing breaking changes.
• [x] Improve and redo configuration and the ExtendedClient class.
  • config.json isn't even used anymore apart from a few isolated instances that can be easily removed.
  • I've already updated the permissions to the modern meta but if I hadn't I'd have put it here as well.
  • ExtendedClient has a ton of useless methods and is overall very outdated.
• [x] Improve image-related commands and make methods more reusable.
  • Pretty self explanatory, most of the image loader is extremely hyperspecific to a certain type of command and you can't customize the output anywhere.
  • This makes using the image loader for anything that's not a slash command with an embed and attachment near-impossible.
  • This is just a random idea but I'm putting it here for good measure: Add buttons for random rotation and flipping on a given tiled embed.
• [x] Use ephemeral messages properly.
  • This goes hand-in-hand with the string loader changes.
  • Currently a bunch of messages that could be ephemeral aren't because the interaction is being deferred early (mostly because it's querying something from the API that can take some time otherwise).
  • Not entirely sure how to solve this since you can only defer a command once, but it would be nice to fix.
• [x] Fix whatever's going on with /missing.
  • Lots of duplicate code, lots of random functions with little documentation and less meaning, and just generally in need of a drastic refactor.
• [x] Remove texture ID quoting and fully use /compare everywhere.
• [x] Create a proper "about" page for the bot (can just be an embed listing details).
• [x] Implement JSDoc everywhere and make everything just generally easier to understand.
• [x] Implement prefix command shorthands for some utility slash commands (e.g. /m, /t, /p), and move it from the submission bot while I'm at it.
• [x] /embed command that lets you construct a one-time custom embed using slash command arguments (generally useful to have).

Might add or remove to this list over time, but it's just a general reference for me (and any other developers) who want to look at the next generation of CompliBot.

[3vorp]

more random stuff I've noticed:

• image folder is really badly documented and even more poorly written, should be drastically refactored
• /missing may be a bit more complicated than just a simple refactor, since multiple files are being affected and ideally there could be proper parameters and return values.
• there's a bunch of commonjs vs es6 conflicts with slash commands and components, they should probably be moved into a better place
• way more stuff is being incorrectly translated or not translated than I thought — much of the crowdin will probably have to be redone, but the string loader works a lot better now thanks to my existing changes

overall the rewrite is coming along pretty smoothly but I just wanted to bring special attention to these before I forget

[3vorp]

another weekly update:

• image stuff is mostly redone now, still need to do magnification, tinting, and paletting but those should be pretty easy since all the infrastructure is done — this also facilitates readding the shorthand prefix commands
• ephemeral stuff is fixed in texture commands using some janky workarounds with completing and instantly deleting the interaction, probably gonna apply elsewhere throughout the bot
• strings still need a full overhaul in terms of what's being translated, but the loader is working fine so that shouldn't be much of a problem
• es6 vs commonjs conflicts are (probably) resolved now using a universal component parser and splitting and extending them as necessary