search

Faithlife / styled-ui

Faithlife UI styleguide and set of components
https://faithlife.github.io/styled-ui/
MIT License
13 stars 50 forks source link

Package updates #503

Closed ddunkin closed 3 years ago

ddunkin commented 3 years ago

I spot checked the output dist/main.js. It's pretty close to the same as before. Some of the generated helper functions are different.

I could figure out what UglifyJS was choking on and see if I could configure babel to generate compatible output, but if IE 11 supports it this output, we're probably fine. Note I have not tested this yet on with IE 11.

ddunkin commented 3 years ago

I'm looking into the test failures.

korbinancell commented 3 years ago

Looks like some linting issues, strange that it would complain here and not on your eslint update pr

ddunkin commented 3 years ago

Where do you see linting issues? It looks like the tests are failing because of console.error messages during the test, mostly from propType problems.

ddunkin commented 3 years ago

the tests are failing because of console.error messages during the test

Those aren't actually test failures. Still looking.

korbinancell commented 3 years ago

Yep, console errors don't actually fail jest tests.