search

Faithlife / styled-ui

Faithlife UI styleguide and set of components
https://faithlife.github.io/styled-ui/
MIT License
13 stars 50 forks source link

Document Bootstrap CSS requirement #520

Closed ELanning closed 3 years ago

ELanning commented 3 years ago

A common thing that needs to be done to setup styled-ui is a global import to bootstrap somewhere.

import 'bootstrap/dist/css/bootstrap.css';

Otherwise things like Text, etc will not have proper fonts and so forth.

I'm raising an issue rather than opening up a PR with the docs, because I'm unsure the "best way" to do this. As well as where we even want to document it.

Thanks!

RobertBolender commented 3 years ago

Unless I'm mistaken, we have removed all traces of Bootstrap in Styled-UI v6. Was this discovered on a project that is still using v5?

ELanning commented 3 years ago

Ah yes, I did a yarn add @faithlife/styled-ui -> I guess this by default pulls in v5.75.1 when I expected "latest" (eg 6.X.X).

Thanks for the help.

RobertBolender commented 3 years ago

Now that we're off of Helmsman, we should be able to fix the "latest" tag to actually point at v6! I'll create an issue so that someone can pick it up for Hacktoberfest :)