FakeByte / EpicOnlineTransport

A Transport for Mirror using Epic Online Services
MIT License
252 stars 52 forks source link

EosTransport should call OnClientDisconnected when client disconnects #47

Open Frechfuchs opened 1 year ago

Frechfuchs commented 1 year ago

Talking about these lines: https://github.com/FakeByte/EpicOnlineTransport/blob/master/Mirror/Runtime/Transport/EpicOnlineTransport/EosTransport.cs#L160-L163

ClientDisconnect should call OnClientDisconnected, which will call NetworkClient.OnTransportDisconnected, which will removes transport handlers, which clients need to remove anything registered in AddTransportHandlers.

An easy fix would be these lines:

public override void ClientDisconnect()
{
    if (!ClientActive()) return;
    Shutdown();
    OnClientDisconnected();
}

Is there a reason not to call OnClientDisconnected here?