search

FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.75k stars 406 forks source link

Cargo Scooter no longer staying in place #10117

Closed SmugFruit closed 2 years ago

SmugFruit commented 2 years ago

Disclaimers

What happened?

I've noticed since the new update that the Cargo Scooter no longer stays in the place where you drop it in the ocean as the description says, and instead slowly falls down at about half the rate of other non buoyant items.

Reproduction steps

  1. Start a new test
  2. Spawnitem cargoscooter cursor
  3. Exit submarine with cargo scooter
  4. Drop cargo scooter in open ocean
  5. Observe how the cargo scooter now slowly descends instead of staying in place

Bug prevalence

Happens every time I play

Version

0.19.11.0

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

Regalis11 commented 2 years ago

Thank you! I'm afraid I could not reproduce this. The scooter does slowly sink, but extremely slowly, nowhere near half the speed of heavier items.

https://user-images.githubusercontent.com/14351070/196892848-3c13d316-e44d-4a98-be01-97e3b6ceaf57.mp4

SmugFruit commented 2 years ago

Ah okay, it was more an approximation rather than anything, as before the update the cargo scooter stayed in place in the water, even in caves, now however it seems to be affected by the currents and sinking now when previously it didn't.

Thought the change in behaviour warranted a bug report as I was informed you changed how buoyancy worked in the update and it may be unintentionally affecting the cargo scooter as I now have to place it above surfaces while exploring as I might lose it while fighting or mining due to it sinking.

Regalis11 commented 2 years ago

Ah, that makes sense. :) It does seem the behavior changed slightly due to the optimizations we did to the buoyancy logic. I did a small adjustment to the logic that should fix the issue: https://github.com/Regalis11/Barotrauma-development/commit/c64f222cde160f22aee711f3051296cbc7460d51.

Lithosagym commented 2 years ago

Tested, cargo scooters stay completely still when dropped. Cargo scooters when spawned through commands sink down for a bit before becoming still again. Issue appears to be fixed.