FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.75k stars 407 forks source link

Forbidden word list not checking descriptions #10948

Closed SquidingTin closed 1 year ago

SquidingTin commented 1 year ago

Disclaimers

What happened?

I've searched for others with this issue, no one seems to have commented on this.

As the title says, if you try blocking words with the forbiddenwordlist.txt it wont hide servers like it should. though if the servers name has a forbidden word in it, then it will block it.

(Small issue)

Reproduction steps

  1. Enable hide forbidden words
  2. See servers with horrible words

Bug prevalence

Happens every time I play

Version

0.20.16.1

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

mygamingaccount commented 1 year ago

Why not extend it to mods too?

Regalis11 commented 1 year ago

Why not extend it to mods too?

I am not sure if you're joking or not, but I don't think this'd be a good idea: the filter isn't foolproof, and can easily cause false positives, but that's not a huge issue with the server names because the host gets notified of the flagged word and can change the name accordingly if they want to. But if the filter applied to mods as well, and you wanted to play with a submarine called Scunthorpe or a mod that adds shitake mushrooms as a gardening options, you'd be out of luck.

I think the same applies (although to a lesser extent) to the server descriptions: with a potentially much longer text like this, the risk of false positives is higher, and the false positives might be harder to work around. So I'm not entirely sure if we should actually take measures to address this.

mygamingaccount commented 1 year ago

Don't know what word you can combine Waifu with that will make it less offensive

SquidingTin commented 1 year ago

mods are to far clearly, but server descriptions should be something that looked into as i dont want to join servers where the description makes me have to look up swear words just to know what they mean

mygamingaccount commented 1 year ago

It depends on the word list. With the correct list you will be able to filter out many lobbies you would have no interest in joining due to the mods used.

For example, I have no interest in loading untested third party Lua source code into a video game which was not designed with security in mind. You should only do that with friends you know well.

https://github.com/Regalis11/Barotrauma/compare/master...mygamingaccount:Barotrauma:wordfilter

Regalis11 commented 1 year ago

We're cleaning up some low-prio/unreproducible/irrelevant/outdated tickets from the issue tracker, and this is one of the tickets we chose to axe. Closing.