FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.76k stars 406 forks source link

On older saves you can store any items in the new container slots on cabinets #12424

Closed Rokvach closed 1 year ago

Rokvach commented 1 year ago

Disclaimers

What happened?

I think there should be some restrictions as to which items can be stored there as well as we shouldn't autosort those slots either because what happens is that it will pull all the storage containers out of those slots every time you sort the cabinet.

image

Reproduction steps

  1. Load up a older save, I was using the "Too many items" save which we've used for performance benchmarking previously
  2. Notice that you can put any item on the container slots even though it only takes one of those items
  3. Place storage containers on the container slots and press auto sort, notice that the storage containers gets moved out of the slots into the main cabinet slots. Also if you have a cabinet full of items and you auto sort it will populate the container slots with a random item from the cabinet.

Bug prevalence

Happens every time I play

Single player or multiplayer?

Happens in both single player and multiplayer

-

No response

Version

Unstable (v1.1.3.0)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

Regalis11 commented 1 year ago

Addressed in https://github.com/Regalis11/Barotrauma-development/commit/ffedca373c81af8821f9b6b85f8b7968f06ee496

Rokvach commented 1 year ago

Tested, working correctly. Can be merged and closed.