FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.72k stars 400 forks source link

Sorting/moving partially broken `huskeggbasic` is annoying #13207

Closed BiffW closed 7 months ago

BiffW commented 8 months ago

Disclaimers

What happened?

husk_egg_basic I know it's been like this for a while and maybe it is intentional, but seriously I wish this gets fixed. If you still want to keep it, maybe you should add a button to quick combine broken items(if they are combinable) just like that quick stack button or merge this functionality into that button.

Reproduction steps

  1. store a lot of huskeggbasic in a container
  2. crate some fire or explosions to damage the eggs
  3. enjoy sorting/moving these broken eggs one by one

Bug prevalence

Happens regularly

Single player or multiplayer?

Happens in both single player and multiplayer

-

No response

Version

v1.2.7.0 (Winter Update hotfix)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

ubertpendragon commented 8 months ago

It's not just husk eggs

image

Fruits still take 50% damage on an explosion (from the fire tick that triggers OnFire), can't be stacked back together, and cannot be used for crafting

image

The simplest solution is to give them all 1 health so there wont partial/damaged fruits. It won't really make a difference if the fruit dies in 1 frame of fire / 1 explosion instead of 2 seconds / 2 explosions; the fruits are unuseable either way if they go below 100% condition

This is a callback to https://github.com/Regalis11/Barotrauma/issues/12557.

Items that are vulnerable to fire using OnFire SEs will get damaged by explosions, either on top or regardless of having damagedbyexplosions="true/false"

pavel4win commented 8 months ago

It is your own fault. Why do you not keep flammable items in fireproof containers as "Storage Container" or "Toolbelt"?

Regalis11 commented 8 months ago

Addressed in https://github.com/Regalis11/Barotrauma-development/commit/47c92406fb3bdfe7243c76f03cc3a5c7c364776b

It is your own fault. Why do you not keep flammable items in fireproof containers as "Storage Container" or "Toolbelt"?

Arguably yes, but in my opinion this behavior doesn't add anything interesting to the game. It's just an annoyance to deal with these partially broken items. And if the player was expected to store these items in fireproof containers, it should be communicated in some way; it's not at all obvious that items like these need to be protected from fire, when many other items that should logically be flammable don't need to be.

Rokvach commented 7 months ago

Tested, working correctly. Closing.